mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.
Date Mon, 10 Oct 2016 15:32:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52556/#review151918
-----------------------------------------------------------




src/launcher/executor.cpp (lines 903 - 910)
<https://reviews.apache.org/r/52556/#comment220614>

    You didn't start this but I wonder why we can't consistently use the flags, which can
be provided through environment variables, i.e., use `flags.load("MESOS_", &argc, &argv);`
above.
    
    That question aside, I don't think we need to be concerned about backwards-compatibility
here: this is the command executor bundled with the agent so they are upgraded together. i.e.,
we are sure that the agent is setting the new variable.



src/slave/slave.cpp (lines 4328 - 4331)
<https://reviews.apache.org/r/52556/#comment220662>

    Same here. Since the logic here is specific for the bundled command executor, I don't
think there's backwards-compatibility concerns here. We can just change it.



src/slave/slave.cpp (line 6847)
<https://reviews.apache.org/r/52556/#comment220578>

    I asked about this on slack then started discussing it on the dev list. I'd say we don't
comment on the deprecation until we reach conclusion on that thread.


- Jiang Yan Xu


On Oct. 10, 2016, 5:35 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52556/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 5:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6288
>     https://issues.apache.org/jira/browse/MESOS-6288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This environment variable points to the directory containing the
> binaries used by the Mesos Agent. It will eventually replace the
> `--launcher-dir` executor flag.
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
>   src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
>   src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306 
> 
> Diff: https://reviews.apache.org/r/52556/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message