mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52676: Made stout's tests a phony target.
Date Mon, 10 Oct 2016 14:38:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52676/#review151982
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52676]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 10, 2016, 11:54 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52676/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 11:54 a.m.)
> 
> 
> Review request for mesos, Kapil Arya and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the stout root folder contains a folder `tests/` so the automake
> build target `tests` conflicts that one. This e.g., leads to the
> `tests` target no being built unless a user executes e.g.,
> 
>     % make check
> 
> Make `tests` a phony target to avoid the name conflict.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am fda069d0f7d75ca80b56eadac415cba57afb03f7 
> 
> Diff: https://reviews.apache.org/r/52676/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message