mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.
Date Mon, 10 Oct 2016 14:33:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52561/#review151980
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 376)
<https://reviews.apache.org/r/52561/#comment220655>

    If you rename slave -> agent in this test, why not in all others in this file? Please
either rename all accurencies, or not at all.


- Alexander Rukletsov


On Oct. 7, 2016, 2:40 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52561/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 2:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed `flags` to `agentFlags` in health check test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 
> 
> Diff: https://reviews.apache.org/r/52561/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message