mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 52690: Added 3rdparty build byproducts to cmake setup.
Date Mon, 10 Oct 2016 12:59:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52690/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Bugs: MESOS-5656
    https://issues.apache.org/jira/browse/MESOS-5656


Repository: mesos


Description
-------

We depend on certain artifacts in built 3rdparty components. With the
make generator just defining it appears just defining an external
project is good enough since make just uses these as order-only
targets. With the ninja generator on the other hand this appears to be
insufficient as its dependency graph analysis detects that 3rdparty
libraries we are about to link against do not exist and no explicit
rule defines a recipe exists to generate them.

This commits adds BUILD_BYPRODUCTS clauses for zookeeper and leveldb.


Diffs
-----

  3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 

Diff: https://reviews.apache.org/r/52690/diff/


Testing
-------

`ninja test`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message