mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 50493: Added `base` to PIDGroup.
Date Mon, 10 Oct 2016 06:50:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50493/
-----------------------------------------------------------

(Updated Oct. 10, 2016, 6:50 a.m.)


Review request for mesos and Joseph Wu.


Changes
-------

rebase. Need some more discussion on the opened issues.


Bugs: MESOS-5828
    https://issues.apache.org/jira/browse/MESOS-5828


Repository: mesos


Description
-------

All subclasses derived from PIDGroup are required to have `base`
as a set of PIDs that always exist from the beginning. Therefore
`base` is refactored into PIDGroup base class. This is a step
towards modularizing replicated_log's PIDGroup abstraction.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
  3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50493/diff/


Testing
-------

see end of review chain


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message