mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 50491: Added PIDGroup to libprocess.
Date Mon, 10 Oct 2016 06:48:02 GMT


> On Sept. 30, 2016, midnight, Joseph Wu wrote:
> > 3rdparty/libprocess/include/process/pid_group.hpp, line 98
> > <https://reviews.apache.org/r/50491/diff/3/?file=1464094#file1464094line98>
> >
> >     Hm, why is this in the header?  It can easily go into the .cpp file.

`PIDGroup::broadcast` is using template function `PIDGroupProcess::broadcast`, therefore needs
to have it in header as well. Not really sure how to move this definition into cpp without
causing complition error...


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50491/#review150959
-----------------------------------------------------------


On Oct. 10, 2016, 6:43 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50491/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Log network is not specific to replicated log and the name 'network'
> is also confusing. Therefore, PIDGroup is added to libprocess as a
> replacement for network. This is a step towards modularizing the
> PIDGroup abstraction alongside the `MasterContender` and
> `MasterDetector`.
> 
> Note: The PIDGroup abstraction is a component that discovers all masters
> in the group; whereas the `MasterDetector` only discovers the leader
> of the group. Both are necessary for the replicated log.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 020b0e1e4c49805a3c7a61b308d897fc82f5e0ce 
>   3rdparty/libprocess/include/Makefile.am 17c5d11463d0fa16f7039e8395146a62e38deece 
>   3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
>   3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/pid_group_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50491/diff/
> 
> 
> Testing
> -------
> 
> see the end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message