mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52668: Refactored nested container tests launcher orphans.
Date Sun, 09 Oct 2016 20:15:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52668/#review151942
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52667, 52668]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 9, 2016, 6:27 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52668/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2016, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changed the way we simulate orphans in nested container
> tests, by removing the container's runtime directory, so that we
> no longer rely on creating freezer cgroup which is specific to
> linux launcher.
> 
> Some cleanup and nits fixed are included in this patch as well.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 9b278e546dacc14b10dac51ee50e8fb89df86b87

> 
> Diff: https://reviews.apache.org/r/52668/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message