mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.
Date Sat, 08 Oct 2016 14:02:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52659/#review151924
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704,
50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021,
51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913, 51953, 51954, 51955, 51956, 51957,
51958, 52039, 52083, 52656, 52657, 52658, 52659]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 7, 2016, 11:52 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52659/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 11:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6329
>     https://issues.apache.org/jira/browse/MESOS-6329
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a task launch fails due to a transient error (e.g., insufficient
> available resources at an agent), the master sends a TASK_LOST update to
> the framework. For PARTITION_AWARE frameworks, we now send TASK_DROPPED
> instead.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 8837f3d55be99626f79ed7f88eee021f115a2889 
>   src/tests/master_authorization_tests.cpp a4623d15c246651fd1038fdedf16321b1d5f273f 
>   src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 
> 
> Diff: https://reviews.apache.org/r/52659/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message