mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52470: Set executor id in `protobuf::createTask`.
Date Sat, 08 Oct 2016 12:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/
-----------------------------------------------------------

(Updated Oct. 8, 2016, 12:20 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6283
    https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
-------

Set executor id in `protobuf::createTask`.


Diffs
-----

  src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 
  src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
  src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 
  src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 
  src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2 
  src/slave/http.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8 
  src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
  src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
  src/tests/common/http_tests.cpp aea338674f1a3b769958af134d1435292b827ba7 
  src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 

Diff: https://reviews.apache.org/r/52470/diff/


Testing (updated)
-------

Add a new test case `CommandExecutorTest.EmptyExecutorIdInTask`.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message