mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.
Date Sat, 08 Oct 2016 06:07:32 GMT


> On Oct. 7, 2016, 7:33 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/controllers.js, line 58
> > <https://reviews.apache.org/r/52471/diff/3/?file=1526986#file1526986line58>
> >
> >     s/===/==/ ?

In javascript, we prefer `===` instead of `==`, because `==` may true when they are not different.

```
grep -c ' === ' src/webui/master/static/js/controllers.js
12

grep -c ' == ' src/webui/master/static/js/controllers.js
1
```


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151854
-----------------------------------------------------------


On Oct. 7, 2016, 6:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
>     https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent_executor.html 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2

>   src/webui/master/static/framework.html bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4

> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message