mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.
Date Sat, 08 Oct 2016 04:44:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52596/#review151916
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52597, 52596]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Oct. 6, 2016, 7:32 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52596/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 7:32 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6118
>     https://issues.apache.org/jira/browse/MESOS-6118
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is legal to have entries in a `MountInfoTable` whose `entry.id` is
> the same as `entry.parent`. This can happen (for example), if a system
> boots from the network and then keeps the original `/` in RAM.
> However, to avoid cycles when walking the mount hierarchy, we should
> not treat these entries as children of their parent so we skip them.
> 
> This commit adds functionality to handle this case.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 4b10141a49dfb3c6defdb07e295eb14cfcdd36ce 
> 
> Diff: https://reviews.apache.org/r/52596/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j40 check
> GTEST_FILTER="FsTest.MountInfoTableReadSorted" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message