mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Pravat <dpra...@outlook.com>
Subject Re: Review Request 52544: Introduced `FileDesc` class.
Date Sat, 08 Oct 2016 04:13:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52544/
-----------------------------------------------------------

(Updated Oct. 8, 2016, 4:13 a.m.)


Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael Park.


Repository: mesos


Description
-------

On POSIX the `socket`,`pipe` and the `filedescriptor` are
represented by an int type. In Windows a socket is kept in a
`SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and
a file descriptor in an int. Ths class unifies all Windows types.
In POSIX this class defaults to int (can be easily extended).


Diffs (updated)
-----

  3rdparty/libprocess/src/io.cpp d930ceebc90468e082b984e41385549f906dc6ae 
  3rdparty/stout/include/stout/net.hpp 083b8d1959dcd305d0aa8892082b39cb03786ebf 
  3rdparty/stout/include/stout/os.hpp c38e434d90c8c25570118c255f2eec72f96b348d 
  3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/mktemp.hpp 2dfd35605eb4202a5475fe0e0d2f1fd27690a2de 
  3rdparty/stout/include/stout/os/open.hpp 2a357926860b1523c51f12c7edee2babe6afbfa3 
  3rdparty/stout/include/stout/os/read.hpp d0b657db5b7dc0c1e11edc13fd6830a9f6273867 
  3rdparty/stout/include/stout/os/socket.hpp e9d9306e63aff2be083b4254fbf6f31c37edc424 
  3rdparty/stout/include/stout/os/touch.hpp 84d49bb8adc2612e380f037fd42c47166d55f593 
  3rdparty/stout/include/stout/os/windows/close.hpp 9f1566bff19ee872418bce8a43a119c4f0a70a7c

  3rdparty/stout/include/stout/os/windows/fcntl.hpp 2bc794a405e59d80c1e8308c0049d2306347adfa

  3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/read.hpp 09190f97f33db5dfa023f937f8f2a4a62ed1ec15

  3rdparty/stout/include/stout/os/windows/shell.hpp 0ababb4ff76d55d82b8d528f54c99bd4b231b21b

  3rdparty/stout/include/stout/os/windows/socket.hpp 1f6551bc30cf31842513df0fed43ee134c620ebd

  3rdparty/stout/include/stout/os/windows/write.hpp 23488708ae366b8571bb8b4805f67d2054223fff

  3rdparty/stout/include/stout/os/write.hpp 24a69d8f60efd3c2888d464d75164c758b3701a2 
  3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038 
  3rdparty/stout/include/stout/protobuf.hpp 80cb20f40a7ddd4309d27973eef9fca9e4052b64 
  3rdparty/stout/include/stout/windows/os.hpp 7d6530e37e389a314185e5aaa85d8096a28b9c41 
  3rdparty/stout/tests/os/filesystem_tests.cpp e3894ef6f21c15845085400a0d3426520411788e 

Diff: https://reviews.apache.org/r/52544/diff/


Testing
-------


Thanks,

Daniel Pravat


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message