mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.
Date Sat, 08 Oct 2016 02:57:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52347/#review151909
-----------------------------------------------------------


Fix it, then Ship it!




I would fix these while committing.


include/mesos/master/master.proto (line 468)
<https://reviews.apache.org/r/52347/#comment220571>

    I modified this to be as per my earlier review comment:
    
    ```cpp
    // This is the status of the task corresponding to the last status update acknowledged
by the scheduler.
    ```



src/master/master.cpp (lines 7589 - 7590)
<https://reviews.apache.org/r/52347/#comment220565>

    Kill this since we already added a comment when we defined the variable.


- Anand Mazumdar


On Oct. 7, 2016, 5:19 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52347/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 5:19 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5936
>     https://issues.apache.org/jira/browse/MESOS-5936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Send last `TaskStatus` in `TaskUpdated`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto d2312dce31f56dd65ac4d0e554b680749da61335 
>   include/mesos/v1/master/master.proto 0dc6cca367590ea8e9f22b22b85baa4c11e69b13 
>   src/common/protobuf_utils.hpp 96df060d48d0206cfd745e17dcd568d0fbd032f4 
>   src/common/protobuf_utils.cpp f09b0692ad5b47ac3f4c755a3921d15c242778b4 
>   src/master/master.cpp c7e74df71aa31edb490f4f3bd95f2d5aa94b4324 
>   src/tests/api_tests.cpp 39f3f6641cfb4b2e05cbaa1e8156e8a2f480f87a 
> 
> Diff: https://reviews.apache.org/r/52347/diff/
> 
> 
> Testing
> -------
> 
> unit test.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message