mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 49688: Added cmake build variables for mesos tests.
Date Mon, 03 Oct 2016 23:33:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49688/#review151254
-----------------------------------------------------------



This patch is probably not needed anymore.  We already build the `test-helper`.

Found and fixed an orphan file while reviewing this :)
https://reviews.apache.org/r/52498/


src/tests/containerizer/CMakeLists.txt (lines 19 - 32)
<https://reviews.apache.org/r/49688/#comment219578>

    These two test helpers were somewhat recently combined into a single test helper:
    
    https://github.com/apache/mesos/commits/master/src/tests/test_helper_main.cpp


- Joseph Wu


On Sept. 7, 2016, 11:33 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49688/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 11:33 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The patch simply sets up the mesos-tests target, also defines and sets
> up the required dependencies, includ and lib directories. Target and
> sources are added after building all test dependencies in a patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/cmake/MesosTestsConfigure.cmake 3f543c010ae87ff04e6b45745bc49ef65b6590ff

>   src/tests/containerizer/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49688/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> cmake check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message