mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52462: Ported ReviewBot script to Windows.
Date Mon, 03 Oct 2016 23:27:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52462/#review151252
-----------------------------------------------------------


Fix it, then Ship it!





support/verify_reviews.py (line 178)
<https://reviews.apache.org/r/52462/#comment219573>

    s/print the error/print the output/


- Vinod Kone


On Oct. 1, 2016, 12:34 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52462/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2016, 12:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Alex Clemmer,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes which script ReviewBot uses to apply reviews and 
> what script ReviewBot runs if on Windows.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 
> 
> Diff: https://reviews.apache.org/r/52462/diff/
> 
> 
> Testing
> -------
> 
> On Windows:
> python support/verify_reviews.py a b 1
> // ^ Fake username and password, so as to not post any reviews.
> 
> Tested successful build and unsuccessful build (introduced a syntax error in libprocess).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message