mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52461: Ported apply-reviews.py script to Windows.
Date Mon, 03 Oct 2016 23:14:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52461/#review151250
-----------------------------------------------------------


Fix it, then Ship it!





support/apply-reviews.py (line 166)
<https://reviews.apache.org/r/52461/#comment219568>

    s/your/the/


- Vinod Kone


On Oct. 3, 2016, 6:09 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52461/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Alex Clemmer,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes some of the shell-specific things this script was doing
> in favor of native Python, which works on Windows.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 8dc1817943d7681b90d64c10bcd82acd7b7cef9d 
> 
> Diff: https://reviews.apache.org/r/52461/diff/
> 
> 
> Testing
> -------
> 
> On Windows and OSX:
> python support/apply-reviews.py -n -r <#####>
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message