mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 42860: Added paths::overlapping to check whether paths are overlapping.
Date Mon, 03 Oct 2016 19:14:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42860/#review151195
-----------------------------------------------------------



Code looks great! Just some suggestions for the comments.


3rdparty/stout/include/stout/path.hpp (line 44)
<https://reviews.apache.org/r/42860/#comment219470>

    s/The path need/The path we need/



3rdparty/stout/include/stout/path.hpp (line 45)
<https://reviews.apache.org/r/42860/#comment219471>

    s/overlap with paths exist in tree/overlaps with paths in the tree/



3rdparty/stout/include/stout/path.hpp (line 132)
<https://reviews.apache.org/r/42860/#comment219488>

    Check whether paths in the given list are overlapping.



3rdparty/stout/include/stout/path.hpp (line 135)
<https://reviews.apache.org/r/42860/#comment219489>

    s/under/is under/



3rdparty/stout/include/stout/path.hpp (line 136)
<https://reviews.apache.org/r/42860/#comment219487>

    I also didn't know what "flat" meant here; perhaps you could either explain what it means,
or remove it?



3rdparty/stout/tests/path_tests.cpp (line 179)
<https://reviews.apache.org/r/42860/#comment219484>

    Check path lists containing "/".



3rdparty/stout/tests/path_tests.cpp (line 186)
<https://reviews.apache.org/r/42860/#comment219485>

    Check paths which have the same prefix.


- Greg Mann


On Sept. 12, 2016, 5:29 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42860/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-4521
>     https://issues.apache.org/jira/browse/MESOS-4521
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added paths::overlapping to check whether paths are overlapping.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp d1092f6cccfb9dc53154ce9ce09414d57526a76d 
>   3rdparty/stout/tests/path_tests.cpp 8275e38a503e64d242da6be0fe6bd0a0c21869a3 
> 
> Diff: https://reviews.apache.org/r/42860/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message