| Jiang Yan Xu |
Review Request 52070: Mentioned `reserved_resources_full` info on the agent in relevant docs. |
Mon, 19 Sep, 22:34 |
| Mesos ReviewBot |
Re: Review Request 52070: Mentioned `reserved_resources_full` info on the agent in relevant docs. |
Tue, 20 Sep, 05:55 |
| haosdent huang |
Re: Review Request 52070: Mentioned `reserved_resources_full` info on the agent in relevant docs. |
Tue, 20 Sep, 06:24 |
| Guangya Liu |
Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 22:34 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 22:40 |
| Guangya Liu |
Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 22:52 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 23:01 |
| Guangya Liu |
Re: Review Request 52069: Moved `CHECK_NE` close to the `if (task.isSome())`. |
Mon, 19 Sep, 23:14 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` close to the `if (task.isSome())`. |
Tue, 20 Sep, 00:07 |
| Anindya Sinha |
Review Request 52071: Updated docs to reflect handling of disk resource with size of 0. |
Mon, 19 Sep, 22:44 |
| Mesos ReviewBot |
Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0. |
Tue, 20 Sep, 07:21 |
| Anindya Sinha |
Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0. |
Wed, 21 Sep, 04:15 |
| Mesos ReviewBot |
Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0. |
Wed, 21 Sep, 14:32 |
| Anindya Sinha |
Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0. |
Mon, 26 Sep, 06:52 |
| Anindya Sinha |
Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. |
Mon, 26 Sep, 21:00 |
| Anindya Sinha |
Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. |
Wed, 28 Sep, 19:25 |
| Mesos ReviewBot |
Re: Review Request 52071: Updated docs to handle resources with no size in agent flags. |
Thu, 29 Sep, 01:05 |
|
Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager. |
|
| Joseph Wu |
Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager. |
Tue, 20 Sep, 00:26 |
| Joseph Wu |
Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager. |
Tue, 20 Sep, 00:29 |
| Benjamin Mahler |
Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 00:40 |
| Guangya Liu |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 07:45 |
| Vinod Kone |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 21:30 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 22:02 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 22:28 |
| Guangya Liu |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 09:10 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 21:57 |
| Vinod Kone |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 21:30 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Fri, 23 Sep, 19:45 |
|
Re: Review Request 40411: Libprocess Reinit: Modify test to use PID<MetricsProcess>. |
|
| Joseph Wu |
Re: Review Request 40411: Libprocess Reinit: Modify test to use PID<MetricsProcess>. |
Tue, 20 Sep, 00:41 |
| Greg Mann |
Re: Review Request 40411: Libprocess Reinit: Modify test to use PID<MetricsProcess>. |
Wed, 21 Sep, 22:33 |
| Benjamin Mahler |
Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Tue, 20 Sep, 01:22 |
| Mesos ReviewBot |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Tue, 20 Sep, 08:06 |
| Guangya Liu |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Tue, 20 Sep, 13:27 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Wed, 21 Sep, 22:38 |
| Guangya Liu |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Fri, 23 Sep, 22:26 |
| Vinod Kone |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Tue, 20 Sep, 23:06 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Wed, 21 Sep, 22:42 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Fri, 23 Sep, 19:46 |
| Qian Zhang |
Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Tue, 20 Sep, 03:22 |
| Mesos ReviewBot |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Tue, 20 Sep, 09:35 |
| Vinod Kone |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Thu, 22 Sep, 01:18 |
| Vinod Kone |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Thu, 22 Sep, 01:19 |
| Qian Zhang |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Fri, 23 Sep, 00:17 |
| Kevin Klues |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Fri, 23 Sep, 01:54 |
|
Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'. |
|
| Yubo Li |
Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'. |
Tue, 20 Sep, 06:09 |
|
Re: Review Request 50125: Added mesos-docker-executor support for devices control. |
|
| Yubo Li |
Re: Review Request 50125: Added mesos-docker-executor support for devices control. |
Tue, 20 Sep, 07:34 |
| Yubo Li |
Re: Review Request 50125: Added mesos-docker-executor support for devices control. |
Tue, 20 Sep, 09:26 |
| Yubo Li |
Re: Review Request 50125: Added mesos-docker-executor support for devices control. |
Thu, 22 Sep, 06:21 |
|
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU. |
|
| Yubo Li |
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU. |
Tue, 20 Sep, 08:03 |
| Yubo Li |
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU. |
Tue, 20 Sep, 09:27 |
| Yubo Li |
Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU. |
Thu, 22 Sep, 06:21 |
|
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
|
| Yubo Li |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Tue, 20 Sep, 08:37 |
| Yubo Li |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Tue, 20 Sep, 09:27 |
| Yubo Li |
Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch. |
Thu, 22 Sep, 06:21 |
|
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. |
|
| Yubo Li |
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. |
Tue, 20 Sep, 09:25 |
| Yubo Li |
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. |
Thu, 22 Sep, 06:20 |
| Yubo Li |
Re: Review Request 50599: Assigned Nvidia GPU devices to docker container. |
Tue, 20 Sep, 09:25 |
| Neil Conway |
Review Request 52080: Replaced `Latch*` with `Latch` in executor, scheduler drivers. |
Tue, 20 Sep, 10:32 |
| Neil Conway |
Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized. |
Tue, 20 Sep, 13:11 |
| Michael Park |
Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized. |
Tue, 20 Sep, 14:09 |
| Benjamin Bannier |
Review Request 52081: Reorganized includes in containerizer. |
Tue, 20 Sep, 11:12 |
| Jie Yu |
Re: Review Request 52081: Reorganized includes in containerizer. |
Thu, 22 Sep, 18:42 |
| Benjamin Bannier |
Re: Review Request 52081: Reorganized includes in containerizer. |
Thu, 29 Sep, 16:20 |
|
Review Request 52082: Tweaked initialization order in executor driver. |
|
| Neil Conway |
Review Request 52082: Tweaked initialization order in executor driver. |
Tue, 20 Sep, 13:11 |
| Michael Park |
Re: Review Request 52082: Tweaked initialization order in executor driver. |
Tue, 20 Sep, 14:36 |
| Mesos ReviewBot |
Re: Review Request 52082: Tweaked initialization order in executor driver. |
Tue, 20 Sep, 16:46 |
| Benjamin Bannier |
Review Request 52037: Removed stout's `Set`. |
Tue, 20 Sep, 13:31 |
| Benjamin Bannier |
Re: Review Request 52037: Removed stout's `Set`. |
Tue, 20 Sep, 16:05 |
| Mesos ReviewBot |
Re: Review Request 52037: Removed stout's `Set`. |
Tue, 20 Sep, 19:32 |
| Michael Park |
Re: Review Request 52037: Removed stout's `Set`. |
Wed, 21 Sep, 12:04 |
| Benjamin Bannier |
Review Request 52036: Moved user of stout's `Set` to `std::set`. |
Tue, 20 Sep, 13:31 |
| Benjamin Bannier |
Re: Review Request 52036: Moved user of stout's `Set` to `std::set`. |
Tue, 20 Sep, 16:05 |
| Michael Park |
Re: Review Request 52036: Moved user of stout's `Set` to `std::set`. |
Wed, 21 Sep, 12:04 |
| Neil Conway |
Review Request 52083: Changed reconciliation for unregistering, reregistering agents. |
Tue, 20 Sep, 15:26 |
| Mesos ReviewBot |
Re: Review Request 52083: Changed reconciliation for unregistering, reregistering agents. |
Tue, 20 Sep, 18:14 |
|
Re: Review Request 51986: Modified `cleanup` to be nested container aware. |
|
| Avinash sridharan |
Re: Review Request 51986: Modified `cleanup` to be nested container aware. |
Tue, 20 Sep, 17:10 |
| Jie Yu |
Re: Review Request 51986: Modified `cleanup` to be nested container aware. |
Tue, 20 Sep, 21:20 |
|
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
|
| Gilbert Song |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Tue, 20 Sep, 17:21 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Tue, 20 Sep, 17:29 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Tue, 20 Sep, 17:28 |
| Mesos ReviewBot |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Wed, 21 Sep, 00:24 |
| Jie Yu |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Wed, 21 Sep, 18:26 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Thu, 22 Sep, 21:00 |
| Jie Yu |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Fri, 23 Sep, 17:55 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Fri, 23 Sep, 18:09 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Wed, 21 Sep, 19:34 |
| Zhitao Li |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Thu, 22 Sep, 20:52 |
| Mesos ReviewBot |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Fri, 23 Sep, 02:51 |
| Jie Yu |
Re: Review Request 51124: Support more layers through symlink for overlay backend. |
Fri, 23 Sep, 18:54 |
| haosdent huang |
Review Request 52090: Fixed compile error in ppc64le. |
Tue, 20 Sep, 19:20 |
| Jie Yu |
Re: Review Request 52090: Fixed compile error in ppc64le. |
Tue, 20 Sep, 21:30 |
| haosdent huang |
Re: Review Request 52090: Fixed compile error in ppc64le. |
Wed, 21 Sep, 16:19 |
| haosdent huang |
Re: Review Request 52090: Fixed compile error in ppc64le. |
Wed, 21 Sep, 16:42 |
| haosdent huang |
Re: Review Request 52090: Fixed compile error in ppc64le. |
Wed, 21 Sep, 16:44 |
| Jie Yu |
Re: Review Request 52090: Fixed compile error in ppc64le. |
Wed, 21 Sep, 17:10 |
| haosdent huang |
Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Tue, 20 Sep, 19:21 |
| Jie Yu |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Tue, 20 Sep, 21:33 |
| haosdent huang |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Wed, 21 Sep, 17:26 |
| Mesos ReviewBot |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Wed, 21 Sep, 05:41 |
| haosdent huang |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Wed, 21 Sep, 17:26 |
| Mesos ReviewBot |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Wed, 21 Sep, 22:14 |
| haosdent huang |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Sun, 25 Sep, 09:44 |
| haosdent huang |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Sun, 25 Sep, 17:44 |
| Mesos ReviewBot |
Re: Review Request 52092: Avoided to concat cgroup internally in subsystems. |
Sun, 25 Sep, 19:34 |
| haosdent huang |
Review Request 52091: Replaced `set` to `hashset` in perf interfaces. |
Tue, 20 Sep, 19:22 |
| Jie Yu |
Re: Review Request 52091: Replaced `set` to `hashset` in perf interfaces. |
Tue, 20 Sep, 21:31 |
| haosdent huang |
Re: Review Request 52091: Replaced `set` to `hashset` in perf interfaces. |
Wed, 21 Sep, 16:51 |
| Benjamin Mahler |
Review Request 52057: Introduced an agent API for managing child containers. |
Tue, 20 Sep, 19:26 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Tue, 20 Sep, 19:34 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Tue, 20 Sep, 20:52 |
| Vinod Kone |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Tue, 20 Sep, 23:30 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing nested containers. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing nested containers. |
Fri, 23 Sep, 19:48 |
| Sivaram Kannan |
Review Request 52096: Read user details passed in executorInfo and assign it to user flag. |
Tue, 20 Sep, 19:48 |
| Sivaram Kannan |
Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag. |
Wed, 21 Sep, 01:02 |
| Sivaram Kannan |
Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag. |
Wed, 21 Sep, 03:54 |
| Joseph Wu |
Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag. |
Wed, 21 Sep, 20:13 |
| Sivaram Kannan |
Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Tue, 20 Sep, 19:48 |
| Sivaram Kannan |
Re: Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Wed, 21 Sep, 01:02 |
| Sivaram Kannan |
Re: Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Wed, 21 Sep, 03:54 |
| Mesos ReviewBot |
Re: Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Wed, 21 Sep, 13:04 |
| Joseph Wu |
Re: Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Wed, 21 Sep, 20:29 |
| Joseph Wu |
Re: Review Request 52097: Functionality to switch user when executor launches as non-root user. |
Wed, 21 Sep, 20:39 |
| Sivaram Kannan |
Review Request 52095: Add the new flag for executor launching with different user. |
Tue, 20 Sep, 19:48 |
| Sivaram Kannan |
Re: Review Request 52095: Add the new flag for executor launching with different user. |
Wed, 21 Sep, 01:02 |
| Sivaram Kannan |
Re: Review Request 52095: Add the new flag for executor launching with different user. |
Wed, 21 Sep, 03:54 |
| Joseph Wu |
Re: Review Request 52095: Add the new flag for executor launching with different user. |
Wed, 21 Sep, 20:07 |
| Benjamin Mahler |
Review Request 52098: Updated UUID::fromString to not throw an exception on error. |
Tue, 20 Sep, 21:24 |
| Vinod Kone |
Re: Review Request 52098: Updated UUID::fromString to not throw an exception on error. |
Tue, 20 Sep, 23:31 |
| Benjamin Mahler |
Review Request 52099: Updated scheduler library to handle UUID parsing error. |
Tue, 20 Sep, 21:24 |
| Vinod Kone |
Re: Review Request 52099: Updated scheduler library to handle UUID parsing error. |
Tue, 20 Sep, 23:32 |
|
Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers. |
|
| Joseph Wu |
Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers. |
Tue, 20 Sep, 21:25 |
| Greg Mann |
Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers. |
Thu, 22 Sep, 15:12 |
| Benjamin Mahler |
Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Tue, 20 Sep, 21:28 |
| Vinod Kone |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Tue, 20 Sep, 23:48 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Thu, 22 Sep, 05:55 |
| Guangya Liu |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Wed, 21 Sep, 02:39 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Thu, 22 Sep, 05:55 |
| Mesos ReviewBot |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Wed, 21 Sep, 10:20 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of *_NESTED_CONTAINER calls in the agent API. |
Fri, 23 Sep, 19:48 |
| Charles Allen |
Review Request 52105: Add smarter master redirects. |
Tue, 20 Sep, 23:35 |
|
Re: Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp. |
|
| Michael Park |
Re: Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp. |
Wed, 21 Sep, 00:12 |
| Timothy Chen |
Re: Review Request 46264: Fixed a typo in docker_containerizer_tests.cpp. |
Wed, 21 Sep, 01:47 |
| Vinod Kone |
Review Request 52106: Updated the default executor to not automatically send TASK_FINISHED. |
Wed, 21 Sep, 01:13 |
| Anand Mazumdar |
Re: Review Request 52106: Updated the default executor to not automatically send TASK_FINISHED. |
Wed, 21 Sep, 01:17 |
| Vinod Kone |
Review Request 52107: Updated default executor to set `healthy` status in status update. |
Wed, 21 Sep, 01:13 |
| Anand Mazumdar |
Re: Review Request 52107: Updated default executor to set `healthy` status in status update. |
Wed, 21 Sep, 01:18 |
| Vinod Kone |
Review Request 52108: Updated default executor to send TASK_KILLED updates. |
Wed, 21 Sep, 01:14 |
| Anand Mazumdar |
Re: Review Request 52108: Updated default executor to send TASK_KILLED updates. |
Wed, 21 Sep, 02:04 |
| Guangya Liu |
Re: Review Request 52108: Updated default executor to send TASK_KILLED updates. |
Wed, 21 Sep, 03:33 |
|
Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration. |
|
| Joseph Wu |
Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration. |
Wed, 21 Sep, 01:17 |
| Zhitao Li |
Review Request 52103: Implement quota update through `PUT` method. |
Wed, 21 Sep, 02:29 |
| Mesos ReviewBot |
Re: Review Request 52103: Implement quota update through `PUT` method. |
Wed, 21 Sep, 09:38 |
| Guangya Liu |
Review Request 52109: Missing `endl` in `cout` for default executor. |
Wed, 21 Sep, 03:32 |
| Vinod Kone |
Re: Review Request 52109: Missing `endl` in `cout` for default executor. |
Wed, 21 Sep, 04:09 |