From reviews-return-45664-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Sep 19 22:43:16 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA14519B45 for ; Mon, 19 Sep 2016 22:43:15 +0000 (UTC) Received: (qmail 18507 invoked by uid 500); 19 Sep 2016 22:43:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 18478 invoked by uid 500); 19 Sep 2016 22:43:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18459 invoked by uid 99); 19 Sep 2016 22:43:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2016 22:43:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EEABE2D3F6B; Mon, 19 Sep 2016 22:43:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7647382065506454820==" MIME-Version: 1.0 Subject: Re: Review Request 52001: Allow text based disk resources to indicate source type and root. From: Anindya Sinha To: Jiang Yan Xu Cc: Anindya Sinha , haosdent huang , Guangya Liu , mesos Date: Mon, 19 Sep 2016 22:43:12 -0000 Message-ID: <20160919224312.25295.25001@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52001/ X-Sender: Anindya Sinha References: <20160919050113.25296.5128@reviews.apache.org> In-Reply-To: <20160919050113.25296.5128@reviews.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos --===============7647382065506454820== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/ ----------------------------------------------------------- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan Xu. Changes ------- Minor updates based on review comments. Bugs: MESOS-6062 https://issues.apache.org/jira/browse/MESOS-6062 Repository: mesos Description ------- Text based representation of disk resources can indicate source type (ie. PATH or MOUNT) and its root. This makes it closer to the JSON representation. Diffs (updated) ----- src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 Diff: https://reviews.apache.org/r/52001/diff/ Testing ------- Thanks, Anindya Sinha --===============7647382065506454820==--