| Benjamin Mahler |
Review Request 52099: Updated scheduler library to handle UUID parsing error. |
Tue, 20 Sep, 21:24 |
| Benjamin Mahler |
Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Tue, 20 Sep, 21:28 |
| Benjamin Mahler |
Review Request 52134: Pulled out the mock containerizer into a header for reuse. |
Wed, 21 Sep, 21:15 |
| Benjamin Mahler |
Review Request 52135: Implemented the NESTED_CONTAINER_* calls in the agent API. |
Wed, 21 Sep, 21:24 |
| Benjamin Mahler |
Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess. |
Wed, 21 Sep, 21:33 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 21:57 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 22:02 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Wed, 21 Sep, 22:28 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Wed, 21 Sep, 22:38 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Wed, 21 Sep, 22:42 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Thu, 22 Sep, 05:55 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Thu, 22 Sep, 05:55 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing nested containers. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 06:05 |
| Benjamin Mahler |
Re: Review Request 52134: Pulled out the mock containerizer into a header for reuse. |
Thu, 22 Sep, 06:06 |
| Benjamin Mahler |
Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 06:06 |
| Benjamin Mahler |
Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 19:45 |
| Benjamin Mahler |
Re: Review Request 52134: Pulled out the mock containerizer into a header for reuse. |
Thu, 22 Sep, 19:46 |
| Benjamin Mahler |
Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 19:49 |
| Benjamin Mahler |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Fri, 23 Sep, 19:45 |
| Benjamin Mahler |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Fri, 23 Sep, 19:46 |
| Benjamin Mahler |
Re: Review Request 52057: Introduced an agent API for managing nested containers. |
Fri, 23 Sep, 19:48 |
| Benjamin Mahler |
Re: Review Request 52100: Added validation of *_NESTED_CONTAINER calls in the agent API. |
Fri, 23 Sep, 19:48 |
| Benjamin Mahler |
Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API. |
Fri, 23 Sep, 19:48 |
| Benjamin Mahler |
Re: Review Request 51027: Track allocation candidates to bound allocator. |
Fri, 23 Sep, 22:29 |
| Benjamin Mahler |
Re: Review Request 51027: Track allocation candidates to bound allocator. |
Fri, 23 Sep, 22:30 |
| Benjamin Mahler |
Re: Review Request 52180: Added ExitedEvents for links whose sockets fail on creation. |
Fri, 23 Sep, 23:06 |
| Benjamin Mahler |
Re: Review Request 52182: Prevented a race when relinking with SSL downgrade enabled. |
Sat, 24 Sep, 00:22 |
| Benjamin Mahler |
Re: Review Request 52231: Fixed driver based schedulers to ACK updates from HTTP executors. |
Sat, 24 Sep, 01:27 |
| Benjamin Mahler |
Review Request 52290: Removed resources field from LaunchNestedContainer agent::Call. |
Tue, 27 Sep, 00:10 |
| Benjamin Mahler |
Review Request 52291: Added TODOs to validate against empty task and persistence IDs. |
Tue, 27 Sep, 00:15 |
| Benjamin Mahler |
Review Request 52292: Updated nested container agent API to allow custom ContainerIDs. |
Tue, 27 Sep, 00:16 |
| Benjamin Mahler |
Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs. |
Tue, 27 Sep, 02:38 |
| Benjamin Mahler |
Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs. |
Tue, 27 Sep, 02:38 |
| Benjamin Mahler |
Re: Review Request 52321: Fixed composing containerizer to handled nested containers. |
Wed, 28 Sep, 00:35 |
| Benjamin Mahler |
Review Request 52327: Updated agent to handle false case from nested container launch. |
Wed, 28 Sep, 01:18 |
| Benjamin Mahler |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Wed, 28 Sep, 04:03 |
| Benjamin Mahler |
Re: Review Request 52181: Added synchronization in link logic to prevent relinking races. |
Wed, 28 Sep, 18:48 |
| Benjamin Mahler |
Re: Review Request 52153: Fixed openssl CA location logging. |
Thu, 29 Sep, 19:26 |
| Benjamin Mahler |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Thu, 29 Sep, 20:08 |
| Benjamin Mahler |
Re: Review Request 52329: Fixed logging in composing containerizer. |
Thu, 29 Sep, 22:39 |
| Charles Allen |
Review Request 52105: Add smarter master redirects. |
Tue, 20 Sep, 23:35 |
| Charles Allen |
Re: Review Request 52105: Add smarter master redirects. |
Wed, 21 Sep, 23:41 |
| Charles Allen |
Re: Review Request 52105: Add smarter master redirects. |
Thu, 22 Sep, 19:31 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Thu, 22 Sep, 20:46 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Thu, 22 Sep, 20:47 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Thu, 22 Sep, 20:49 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Fri, 23 Sep, 16:09 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Fri, 23 Sep, 18:04 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Fri, 23 Sep, 18:05 |
| Charles Allen |
Re: Review Request 52105: Prevent `/redirect/foo` loop. |
Wed, 28 Sep, 17:37 |
| Charles Allen |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Wed, 28 Sep, 17:54 |
| Charles Allen |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Wed, 28 Sep, 17:56 |
| Charles Allen |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Wed, 28 Sep, 17:56 |
| Charles Allen |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Wed, 28 Sep, 17:56 |
| Charles Allen |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Wed, 28 Sep, 18:22 |
| Daniel Pravat |
Review Request 51860: Disabled deprecated function warning. |
Tue, 13 Sep, 20:56 |
| Daniel Pravat |
Re: Review Request 51860: Disabled deprecated function warning. |
Tue, 13 Sep, 20:56 |
| Daniel Pravat |
Review Request 51861: Removed macro redefinition. |
Tue, 13 Sep, 22:00 |
| Daniel Pravat |
Review Request 52061: Fixed warnings in `duration.hpp`. |
Mon, 19 Sep, 20:04 |
| Daniel Pravat |
Review Request 52065: Fixed warnings in Windows `shell.hpp`. |
Mon, 19 Sep, 20:04 |
| Daniel Pravat |
Review Request 52063: Fixed warnings in Windows `os.hpp`. |
Mon, 19 Sep, 20:05 |
| Daniel Pravat |
Review Request 52062: Fixed warnings in `numify.hpp`. |
Mon, 19 Sep, 20:05 |
| Daniel Pravat |
Re: Review Request 52062: Fixed warnings in `numify.hpp`. |
Fri, 23 Sep, 04:46 |
| Daniel Pravat |
Review Request 52192: Fixed VC warnings in bytes.hpp. |
Fri, 23 Sep, 04:47 |
| Daniel Pravat |
Review Request 52210: Fixed warnings in getcwd.hpp. |
Fri, 23 Sep, 04:48 |
| Daniel Pravat |
Review Request 52209: Fixed warnings in slave.cpp. |
Fri, 23 Sep, 04:48 |
| Daniel Pravat |
Re: Review Request 52209: Fixed warnings in slave.cpp. |
Fri, 23 Sep, 04:49 |
| Daniel Pravat |
Review Request 52208: Fixed warnings in health_checker.cpp. |
Fri, 23 Sep, 04:50 |
| Daniel Pravat |
Review Request 52207: Fixed warnings in fs.hpp. |
Fri, 23 Sep, 04:50 |
| Daniel Pravat |
Review Request 52206: Fixed warnings in os.hpp. |
Fri, 23 Sep, 04:52 |
| Daniel Pravat |
Review Request 52205: Fixed warnings in flags.hpp. |
Fri, 23 Sep, 04:52 |
| Daniel Pravat |
Review Request 52204: Fixed warnings in socket.hpp. |
Fri, 23 Sep, 04:53 |
| Daniel Pravat |
Review Request 52203: Fixed warnings in metrics.hpp. |
Fri, 23 Sep, 04:54 |
| Daniel Pravat |
Review Request 52202: Fixed warnings in encoder&decoder.hpp. |
Fri, 23 Sep, 04:55 |
| Daniel Pravat |
Review Request 52201: Fixed warnings in timer.hpp. |
Fri, 23 Sep, 04:55 |
| Daniel Pravat |
Review Request 52197: Used intermediate functions. |
Fri, 23 Sep, 04:56 |
| Daniel Pravat |
Review Request 52200: Fixed warnings in system.hpp. |
Fri, 23 Sep, 04:57 |
| Daniel Pravat |
Review Request 52193: Fixed VC warnings in windows.hpp. |
Fri, 23 Sep, 04:57 |
| Daniel Pravat |
Review Request 52194: Added `socket` functions to translate parameters. |
Fri, 23 Sep, 05:04 |
| Daniel Pravat |
Review Request 52196: Fixed warnings in `read/write` functions. |
Fri, 23 Sep, 05:05 |
| Daniel Pravat |
Review Request 52195: Used functions from net:: namespace. |
Fri, 23 Sep, 05:05 |
| Daniel Pravat |
Review Request 52199: Fixed warning in `stout_tests`. |
Fri, 23 Sep, 05:07 |
| Daniel Pravat |
Review Request 52198: Fixed warning in `statistics_tests`. |
Fri, 23 Sep, 05:08 |
| Daniel Pravat |
Re: Review Request 52198: Fixed warning in `statistics_tests`. |
Fri, 23 Sep, 05:09 |
| Daniel Pravat |
Re: Review Request 52196: Fixed warnings in `read/write` functions. |
Mon, 26 Sep, 21:00 |
| Daniel Pravat |
Re: Review Request 52196: Fixed warnings in `read/write` functions. |
Mon, 26 Sep, 21:01 |
| Daniel Pravat |
Re: Review Request 52196: Fixed warnings in `read/write` functions. |
Mon, 26 Sep, 21:15 |
| Daniel Pravat |
Re: Review Request 52194: Added functions to translate parameters. |
Mon, 26 Sep, 21:21 |
| Daniel Pravat |
Re: Review Request 52195: Used functions from `net::` namespace. |
Mon, 26 Sep, 21:37 |
| Daniel Pravat |
Re: Review Request 52062: Fixed warnings in `numify.hpp`. |
Mon, 26 Sep, 21:37 |
| Daniel Pravat |
Review Request 52364: Added basic support to invoke `docker.exe`. |
Wed, 28 Sep, 20:54 |
| Daniel Pravat |
Re: Review Request 52210: Fixed warnings in getcwd.hpp. |
Thu, 29 Sep, 03:32 |
| Daniel Pravat |
Re: Review Request 52210: Fixed warnings in `getcwd.hpp`. |
Thu, 29 Sep, 03:32 |
| Daniel Pravat |
Re: Review Request 52192: Fixed VC warnings in bytes.hpp. |
Thu, 29 Sep, 04:33 |
| Gilbert Song |
Re: Review Request 51592: Added a debug logging for a CHECK failure in MountInfoTable::read. |
Fri, 02 Sep, 07:30 |
| Gilbert Song |
Re: Review Request 51620: Removed two std::move in MountInfoTable::read. |
Sat, 03 Sep, 00:53 |
| Gilbert Song |
Review Request 51668: Changed the nested ContainerID from hashmap to list in memory. |
Tue, 06 Sep, 21:53 |
| Gilbert Song |
Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional. |
Tue, 06 Sep, 21:53 |