| Vinod Kone |
Re: Review Request 51957: Removed "strictness" parameter from RegistrarTest and PartitionTest. |
Fri, 16 Sep, 18:42 |
| Vinod Kone |
Re: Review Request 51958: Removed "registry_strict" master command-line flag. |
Fri, 16 Sep, 18:44 |
| Vinod Kone |
Re: Review Request 51954: Removed the "strict" flag from the registry operation interface. |
Fri, 16 Sep, 19:01 |
| Vinod Kone |
Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag. |
Fri, 16 Sep, 19:01 |
| Vinod Kone |
Re: Review Request 51623: Updated mesos-execute to support task groups. |
Fri, 16 Sep, 19:42 |
| Vinod Kone |
Re: Review Request 51623: Updated mesos-execute to support task groups. |
Fri, 16 Sep, 21:04 |
| Vinod Kone |
Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo. |
Sat, 17 Sep, 18:05 |
| Vinod Kone |
Re: Review Request 51623: Updated mesos-execute to support task groups. |
Sun, 18 Sep, 18:30 |
| Vinod Kone |
Re: Review Request 51991: Added parse function in flags namespace for v1::TaskGroupInfo protobuf. |
Sun, 18 Sep, 18:46 |
| Vinod Kone |
Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo. |
Mon, 19 Sep, 19:02 |
| Vinod Kone |
Re: Review Request 51990: Added << operator to stringify v1::TaskGroupInfo protobuf. |
Mon, 19 Sep, 19:02 |
| Vinod Kone |
Re: Review Request 51623: Updated mesos-execute to support task groups. |
Mon, 19 Sep, 19:20 |
| Vinod Kone |
Re: Review Request 52053: Return 500 rather than 503 when response handlers fail. |
Mon, 19 Sep, 19:22 |
| Vinod Kone |
Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess. |
Mon, 19 Sep, 19:24 |
| Vinod Kone |
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets. |
Mon, 19 Sep, 19:29 |
| Vinod Kone |
Re: Review Request 51921: Added backports for a potential double-close in libevent sockets. |
Mon, 19 Sep, 19:37 |
| Vinod Kone |
Re: Review Request 51958: Removed use of "--registry_strict" master flag. |
Mon, 19 Sep, 20:51 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 22:40 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop. |
Mon, 19 Sep, 23:01 |
| Vinod Kone |
Re: Review Request 52069: Moved `CHECK_NE` close to the `if (task.isSome())`. |
Tue, 20 Sep, 00:07 |
| Vinod Kone |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 21:30 |
| Vinod Kone |
Re: Review Request 52055: Exposed unknown container case from Containerizer::wait. |
Tue, 20 Sep, 21:30 |
| Vinod Kone |
Re: Review Request 52056: Exposed unknown container case from Containerizer::destroy. |
Tue, 20 Sep, 23:06 |
| Vinod Kone |
Re: Review Request 52057: Introduced an agent API for managing child containers. |
Tue, 20 Sep, 23:30 |
| Vinod Kone |
Re: Review Request 52098: Updated UUID::fromString to not throw an exception on error. |
Tue, 20 Sep, 23:31 |
| Vinod Kone |
Re: Review Request 52099: Updated scheduler library to handle UUID parsing error. |
Tue, 20 Sep, 23:32 |
| Vinod Kone |
Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API. |
Tue, 20 Sep, 23:48 |
| Vinod Kone |
Review Request 52106: Updated the default executor to not automatically send TASK_FINISHED. |
Wed, 21 Sep, 01:13 |
| Vinod Kone |
Review Request 52107: Updated default executor to set `healthy` status in status update. |
Wed, 21 Sep, 01:13 |
| Vinod Kone |
Review Request 52108: Updated default executor to send TASK_KILLED updates. |
Wed, 21 Sep, 01:14 |
| Vinod Kone |
Re: Review Request 52109: Missing `endl` in `cout` for default executor. |
Wed, 21 Sep, 04:09 |
| Vinod Kone |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Thu, 22 Sep, 01:18 |
| Vinod Kone |
Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`. |
Thu, 22 Sep, 01:19 |
| Vinod Kone |
Re: Review Request 52134: Pulled out the mock containerizer into a header for reuse. |
Thu, 22 Sep, 17:00 |
| Vinod Kone |
Re: Review Request 52135: Implemented the *_NESTED_CONTAINER calls in the agent API. |
Thu, 22 Sep, 17:23 |
| Vinod Kone |
Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks. |
Fri, 23 Sep, 03:02 |
| Vinod Kone |
Re: Review Request 52143: Added evolve handler for `agent::Call` to `v1::agent::Call`. |
Fri, 23 Sep, 05:02 |
| Vinod Kone |
Re: Review Request 52144: Populated the timestamp field when sending status updates. |
Fri, 23 Sep, 05:03 |
| Vinod Kone |
Re: Review Request 52164: Added `ContainerID` field to the executor `SUBSCRIBED` event. |
Fri, 23 Sep, 05:07 |
| Vinod Kone |
Re: Review Request 52177: Added support for CNI networks for `--task_group`. |
Fri, 23 Sep, 05:16 |
| Vinod Kone |
Re: Review Request 52145: Added support for reading agent API URL in default executor. |
Fri, 23 Sep, 05:19 |
| Vinod Kone |
Re: Review Request 52146: Made `killTask()` invoke `shutdown()`. |
Fri, 23 Sep, 05:25 |
| Vinod Kone |
Re: Review Request 52177: Added support for CNI networks for `--task_group`. |
Fri, 23 Sep, 05:32 |
| Vinod Kone |
Re: Review Request 52177: Added support for CNI networks for `--task_group`. |
Fri, 23 Sep, 05:35 |
| Vinod Kone |
Re: Review Request 52148: Added support for killing child containers to the default executor. |
Sat, 24 Sep, 21:40 |
| Vinod Kone |
Re: Review Request 52149: Added support for waiting on child containers to the default executor. |
Sat, 24 Sep, 21:53 |
| Vinod Kone |
Re: Review Request 52147: Added support for launching child containers to the default executor. |
Sat, 24 Sep, 21:54 |
| Vinod Kone |
Re: Review Request 52149: Added support for waiting on child containers to the default executor. |
Sat, 24 Sep, 21:57 |
| Vinod Kone |
Re: Review Request 52214: Cleaned up some code for managing recovered frameworks. |
Sat, 24 Sep, 21:59 |
| Vinod Kone |
Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks. |
Sat, 24 Sep, 22:02 |
| Vinod Kone |
Re: Review Request 52175: Tweaked test comments. |
Sat, 24 Sep, 22:02 |
| Vinod Kone |
Re: Review Request 52147: Added support for launching child containers to the default executor. |
Mon, 26 Sep, 15:56 |
| Vinod Kone |
Re: Review Request 52147: Added support for launching child containers to the default executor. |
Mon, 26 Sep, 16:26 |
| Vinod Kone |
Re: Review Request 52148: Added support for killing child containers to the default executor. |
Mon, 26 Sep, 16:45 |
| Vinod Kone |
Re: Review Request 52149: Added support for waiting on child containers to the default executor. |
Mon, 26 Sep, 19:41 |
| Vinod Kone |
Re: Review Request 52165: Disabled default executor tests for now. |
Mon, 26 Sep, 22:01 |
| Vinod Kone |
Re: Review Request 52287: Added a test for default executor reconnect upon an process restart. |
Tue, 27 Sep, 01:08 |
| Vinod Kone |
Re: Review Request 52290: Removed resources field from LaunchNestedContainer agent::Call. |
Tue, 27 Sep, 01:10 |
| Vinod Kone |
Re: Review Request 52291: Added TODOs to validate against empty task and persistence IDs. |
Tue, 27 Sep, 01:11 |
| Vinod Kone |
Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs. |
Tue, 27 Sep, 01:18 |
| Vinod Kone |
Review Request 52321: Fixed composing containerizer to handled nested containers. |
Tue, 27 Sep, 22:25 |
| Vinod Kone |
Re: Review Request 52321: Fixed composing containerizer to handled nested containers. |
Wed, 28 Sep, 00:28 |
| Vinod Kone |
Re: Review Request 52317: Fixed default executor to honor the default task group restart policy. |
Wed, 28 Sep, 01:03 |
| Vinod Kone |
Re: Review Request 52326: Added HTTP/TCP health check support to the default executor. |
Wed, 28 Sep, 01:11 |
| Vinod Kone |
Re: Review Request 52327: Updated agent to handle false case from nested container launch. |
Wed, 28 Sep, 01:31 |
| Vinod Kone |
Review Request 52329: Fixed logging in composing containerizer. |
Wed, 28 Sep, 03:14 |
| Vinod Kone |
Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Wed, 28 Sep, 03:15 |
| Vinod Kone |
Re: Review Request 52331: Increased the resources used by the default executor test. |
Wed, 28 Sep, 04:50 |
| Vinod Kone |
Re: Review Request 52328: Added a test for health check failure to the default executor. |
Wed, 28 Sep, 05:16 |
| Vinod Kone |
Re: Review Request 52329: Fixed logging in composing containerizer. |
Thu, 29 Sep, 01:17 |
| Vinod Kone |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Thu, 29 Sep, 01:18 |
| Vinod Kone |
Re: Review Request 52376: Created symlink from child container to task on the default executor. |
Thu, 29 Sep, 04:09 |
| Vinod Kone |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Thu, 29 Sep, 04:12 |
| Vinod Kone |
Re: Review Request 52376: Created symlink from child container to task on the default executor. |
Thu, 29 Sep, 05:55 |
| Vinod Kone |
Re: Review Request 52105: Avoid redirect loop in `/redirect/xxx` in the master. |
Thu, 29 Sep, 19:33 |
| Vinod Kone |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Thu, 29 Sep, 21:09 |
| Vinod Kone |
Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer. |
Thu, 29 Sep, 21:09 |
| Vinod Kone |
Re: Review Request 52407: Added `RecoveryInfo` struct to the agent. |
Thu, 29 Sep, 22:13 |
| Vinod Kone |
Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery. |
Thu, 29 Sep, 22:27 |
| Vinod Kone |
Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery. |
Thu, 29 Sep, 22:59 |
| Vinod Kone |
Re: Review Request 52439: Add Zhitao Li to contributor.yaml. |
Fri, 30 Sep, 19:30 |
| Vinod Kone |
Review Request 52440: Fixed master to properly handle pending tasks. |
Fri, 30 Sep, 19:40 |
| Vinod Kone |
Re: Review Request 52440: Fixed master to properly handle pending tasks. |
Fri, 30 Sep, 20:21 |
| Vinod Kone |
Re: Review Request 52440: Fixed master to properly handle pending tasks. |
Fri, 30 Sep, 20:30 |
| Vinod Kone |
Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container. |
Fri, 30 Sep, 21:03 |
| Will Rouesnel |
Re: Review Request 51257: Add external process container logger. |
Fri, 02 Sep, 11:26 |
| Will Rouesnel |
Re: Review Request 51258: Add documentation for the ExternalContainerLogger module. |
Sun, 04 Sep, 13:48 |
| Will Rouesnel |
Re: Review Request 51257: Add external process container logger. |
Sun, 25 Sep, 03:56 |
| Will Rouesnel |
Re: Review Request 51257: Add external process container logger. |
Sun, 25 Sep, 05:39 |
| Will Rouesnel |
Re: Review Request 51258: Add documentation for the ExternalContainerLogger module. |
Sun, 25 Sep, 05:39 |
| Will Rouesnel |
Re: Review Request 51257: Add external process container logger. |
Sun, 25 Sep, 18:11 |
| Will Rouesnel |
Re: Review Request 51258: Add documentation for the ExternalContainerLogger module. |
Sun, 25 Sep, 18:12 |
| Will Rouesnel |
Re: Review Request 51257: Add external process container logger. |
Mon, 26 Sep, 14:14 |
| Xiaojian Huang |
Re: Review Request 52439: Add Zhitao Li to contributor.yaml. |
Fri, 30 Sep, 20:06 |
| Xiaojian Huang |
Re: Review Request 52439: Add Zhitao Li to contributor.yaml. |
Fri, 30 Sep, 20:14 |
| Yongqiao Wang |
Re: Review Request 51493: Add the query parameter in createRequest. |
Mon, 12 Sep, 00:59 |
| Yubo Li |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Mon, 19 Sep, 06:22 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Mon, 19 Sep, 07:05 |
| Yubo Li |
Re: Review Request 50123: Added GPU scheduler for docker containerizer process. |
Mon, 19 Sep, 07:16 |
| Yubo Li |
Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process. |
Mon, 19 Sep, 07:17 |