| Neil Conway |
Re: Review Request 51653: Handled agents failing health checks multiple times. |
Mon, 12 Sep, 16:01 |
| Neil Conway |
Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions. |
Mon, 12 Sep, 16:01 |
| Neil Conway |
Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state. |
Mon, 12 Sep, 16:02 |
| Neil Conway |
Re: Review Request 51149: Cleaned up 'using' statements. |
Tue, 13 Sep, 10:21 |
| Neil Conway |
Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers. |
Tue, 13 Sep, 10:21 |
| Neil Conway |
Re: Review Request 51151: Moved MockContainerLogger to the single test where it is used. |
Tue, 13 Sep, 10:21 |
| Neil Conway |
Re: Review Request 51152: Moved MockDocker and related declarations to separate files. |
Tue, 13 Sep, 10:21 |
| Neil Conway |
Re: Review Request 51148: Moved MockSlave into a separate header/implementation file. |
Tue, 13 Sep, 10:21 |
| Neil Conway |
Re: Review Request 51149: Cleaned up 'using' statements. |
Tue, 13 Sep, 10:22 |
| Neil Conway |
Re: Review Request 51808: Moved OfferEqMatcher to the single test file where it is used. |
Tue, 13 Sep, 10:24 |
| Neil Conway |
Re: Review Request 51021: Added GC of unreachable agent metadata from the registry. |
Tue, 13 Sep, 12:37 |
| Neil Conway |
Re: Review Request 51021: Added GC of unreachable agent metadata from the registry. |
Tue, 13 Sep, 12:37 |
| Neil Conway |
Re: Review Request 50707: Added test for race between health checks and agent disconnect. |
Tue, 13 Sep, 12:47 |
| Neil Conway |
Re: Review Request 50707: Added test for race between health checks and agent unregistration. |
Tue, 13 Sep, 12:49 |
| Neil Conway |
Review Request 51845: Improved SlaveTest.HealthCheckUnregisterRace. |
Tue, 13 Sep, 12:58 |
| Neil Conway |
Re: Review Request 50707: Added test for race between health checks and agent unregistration. |
Tue, 13 Sep, 12:59 |
| Neil Conway |
Re: Review Request 51653: Handled agents failing health checks multiple times. |
Tue, 13 Sep, 13:10 |
| Neil Conway |
Re: Review Request 51374: Change registry update order on removal, mark-unreachable. |
Tue, 13 Sep, 13:16 |
| Neil Conway |
Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions. |
Tue, 13 Sep, 13:25 |
| Neil Conway |
Re: Review Request 51375: Introduced MockRegistrar. |
Wed, 14 Sep, 10:35 |
| Neil Conway |
Re: Review Request 51375: Introduced MockRegistrar. |
Wed, 14 Sep, 10:40 |
| Neil Conway |
Review Request 51891: Added test case for registry GC race condition. |
Wed, 14 Sep, 15:04 |
| Neil Conway |
Re: Review Request 51375: Introduced MockRegistrar. |
Thu, 15 Sep, 07:36 |
| Neil Conway |
Re: Review Request 51375: Introduced MockRegistrar. |
Thu, 15 Sep, 07:37 |
| Neil Conway |
Review Request 51909: Added benchmarks for new registry operations. |
Thu, 15 Sep, 11:06 |
| Neil Conway |
Re: Review Request 51909: Added benchmarks for new registry operations. |
Thu, 15 Sep, 11:13 |
| Neil Conway |
Review Request 51913: Ignored agent registrations with duplicate agent IDs. |
Thu, 15 Sep, 13:22 |
| Neil Conway |
Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs. |
Thu, 15 Sep, 13:40 |
| Neil Conway |
Re: Review Request 51891: Added test case for registry GC race condition. |
Thu, 15 Sep, 17:59 |
| Neil Conway |
Review Request 51953: Changed registrar operations to no longer depend on "strict" flag. |
Fri, 16 Sep, 12:58 |
| Neil Conway |
Review Request 51954: Removed the "strict" flag from the registry operation interface. |
Fri, 16 Sep, 12:59 |
| Neil Conway |
Review Request 51955: Removed dependency on "registry_strict" in master failover. |
Fri, 16 Sep, 12:59 |
| Neil Conway |
Review Request 51956: Squelched GMock warning in MasterTest.RecoveredSlaveCanReregister. |
Fri, 16 Sep, 12:59 |
| Neil Conway |
Review Request 51957: Removed "strictness" parameter from RegistrarTest and PartitionTest. |
Fri, 16 Sep, 12:59 |
| Neil Conway |
Review Request 51958: Removed "registry_strict" master command-line flag. |
Fri, 16 Sep, 13:00 |
| Neil Conway |
Review Request 51967: Changed return type of `os::pagesize` in stout. |
Fri, 16 Sep, 19:02 |
| Neil Conway |
Review Request 51968: Simplified usage of `os::pagesize` in Mesos. |
Fri, 16 Sep, 19:02 |
| Neil Conway |
Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag. |
Fri, 16 Sep, 19:15 |
| Neil Conway |
Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag. |
Fri, 16 Sep, 19:23 |
| Neil Conway |
Re: Review Request 51954: Removed the "strict" flag from the registry operation interface. |
Fri, 16 Sep, 19:37 |
| Neil Conway |
Re: Review Request 51958: Removed use of "--registry_strict" master flag. |
Sat, 17 Sep, 14:23 |
| Neil Conway |
Review Request 51983: Avoided passing large object by value. |
Sat, 17 Sep, 15:05 |
| Neil Conway |
Review Request 51984: Cleaned up initialization of atomic fields in ProcessManager. |
Sat, 17 Sep, 15:25 |
| Neil Conway |
Re: Review Request 51376: Adjusted existing tests to use MockRegistrar. |
Mon, 19 Sep, 13:15 |
| Neil Conway |
Review Request 52039: Avoided using SIGUSR1 in two test cases. |
Mon, 19 Sep, 14:54 |
| Neil Conway |
Review Request 52080: Replaced `Latch*` with `Latch` in executor, scheduler drivers. |
Tue, 20 Sep, 10:32 |
| Neil Conway |
Re: Review Request 52080: Ensured that `Latch*` in exec, sched drivers is initialized. |
Tue, 20 Sep, 13:11 |
| Neil Conway |
Review Request 52082: Tweaked initialization order in executor driver. |
Tue, 20 Sep, 13:11 |
| Neil Conway |
Review Request 52083: Changed reconciliation for unregistering, reregistering agents. |
Tue, 20 Sep, 15:26 |
| Neil Conway |
Review Request 52113: Fixed an uninitialized variable warning. |
Wed, 21 Sep, 08:47 |
| Neil Conway |
Re: Review Request 52113: Fixed an uninitialized variable warning. |
Wed, 21 Sep, 08:58 |
| Neil Conway |
Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity. |
Thu, 22 Sep, 08:51 |
| Neil Conway |
Review Request 52085: Replaced usage of `strcpy` in stout. |
Thu, 22 Sep, 09:58 |
| Neil Conway |
Review Request 52086: Cleaned up header includes in stout. |
Thu, 22 Sep, 09:58 |
| Neil Conway |
Re: Review Request 52086: Cleaned up header includes in stout. |
Thu, 22 Sep, 14:11 |
| Neil Conway |
Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks. |
Thu, 22 Sep, 21:12 |
| Neil Conway |
Review Request 52175: Tweaked test comments. |
Thu, 22 Sep, 21:12 |
| Neil Conway |
Review Request 52214: Cleaned up some code for managing recovered frameworks. |
Fri, 23 Sep, 11:13 |
| Neil Conway |
Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks. |
Fri, 23 Sep, 11:15 |
| Neil Conway |
Re: Review Request 52174: Fixed bug with unreachable tasks and disconnected frameworks. |
Fri, 23 Sep, 11:17 |
| Neil Conway |
Re: Review Request 52175: Tweaked test comments. |
Fri, 23 Sep, 11:21 |
| Neil Conway |
Re: Review Request 52222: Changed the name of a constant in the tests. |
Fri, 23 Sep, 21:05 |
| Pierre Cheynier |
Re: Review Request 50661: Documentation: fix broken links. |
Fri, 02 Sep, 16:35 |
| Qian Zhang |
Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent. |
Thu, 01 Sep, 05:48 |
| Qian Zhang |
Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent. |
Fri, 02 Sep, 07:20 |
| Qian Zhang |
Re: Review Request 51620: Removed two std::move in MountInfoTable::read. |
Sun, 04 Sep, 00:26 |
| Qian Zhang |
Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner. |
Sun, 04 Sep, 09:18 |
| Qian Zhang |
Re: Review Request 51402: Added nested container check in provisioner destroy. |
Mon, 05 Sep, 09:51 |
| Qian Zhang |
Re: Review Request 51402: Added nested container check in provisioner destroy. |
Mon, 05 Sep, 14:38 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Tue, 06 Sep, 11:38 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Tue, 06 Sep, 23:22 |
| Qian Zhang |
Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent. |
Wed, 07 Sep, 01:32 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Wed, 07 Sep, 06:08 |
| Qian Zhang |
Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint. |
Wed, 07 Sep, 07:27 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Wed, 07 Sep, 13:54 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Wed, 07 Sep, 14:03 |
| Qian Zhang |
Re: Review Request 51674: Supported mesos containerizer destroy to be nested aware. |
Fri, 09 Sep, 02:42 |
| Qian Zhang |
Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`. |
Sun, 11 Sep, 14:22 |
| Qian Zhang |
Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases. |
Sun, 11 Sep, 14:28 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Mon, 12 Sep, 02:55 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Mon, 12 Sep, 03:09 |
| Qian Zhang |
Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency. |
Mon, 12 Sep, 05:19 |
| Qian Zhang |
Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers. |
Mon, 12 Sep, 05:44 |
| Qian Zhang |
Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`. |
Mon, 12 Sep, 08:03 |
| Qian Zhang |
Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency. |
Tue, 13 Sep, 00:03 |
| Qian Zhang |
Re: Review Request 51804: Fixed typos in subprocess_base.hpp. |
Tue, 13 Sep, 00:09 |
| Qian Zhang |
Re: Review Request 51794: Updated `ROOT_CGROUPS_CFS_Big_Quota` to test a CFS quota with decimal. |
Tue, 13 Sep, 03:01 |
| Qian Zhang |
Re: Review Request 51835: Support changing the cgroup owner for command tasks that has rootfs. |
Tue, 13 Sep, 07:43 |
| Qian Zhang |
Re: Review Request 51794: Updated `ROOT_CGROUPS_CFS_Big_Quota` to test a CFS quota with decimal. |
Tue, 13 Sep, 08:34 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Tue, 13 Sep, 14:44 |
| Qian Zhang |
Re: Review Request 51878: Fixed a typo in `CpuIsolatorTest.ROOT_SystemCpuUsage`. |
Wed, 14 Sep, 01:59 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Wed, 14 Sep, 02:38 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Thu, 15 Sep, 08:57 |
| Qian Zhang |
Re: Review Request 46187: Terminate when receiving the ACK of terminal status update. |
Thu, 15 Sep, 09:53 |
| Qian Zhang |
Re: Review Request 45491: Refactored subprocess options [1/2]. |
Sat, 17 Sep, 03:21 |
| Qian Zhang |
Re: Review Request 45491: Refactored subprocess options [1/2]. |
Sat, 17 Sep, 07:25 |
| Qian Zhang |
Re: Review Request 45492: Used ChildHooks in Mesos [2/2]. |
Sat, 17 Sep, 14:09 |
| Qian Zhang |
Re: Review Request 52006: Supported docker/volume isolator to be nested aware. |
Sun, 18 Sep, 23:40 |
| Qian Zhang |
Re: Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2]. |
Mon, 19 Sep, 00:35 |
| Qian Zhang |
Re: Review Request 52018: Renamed Hook to ParentHook in Mesos. |
Mon, 19 Sep, 00:39 |