mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52459: Ignored error in posix launcher destroy if the container is unknown.
Date Fri, 30 Sep 2016 23:27:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52459/#review151105
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Sept. 30, 2016, 4:17 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52459/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is consistent to what we do in linux launcher. A container can be
> destroyed in launcher but not yet fully cleaned up in isolators. If
> agent restarts, we should still allow the cleanup of those containers.
> So launcher should ignore destroy request for unknown containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launcher.cpp 5d1410da40128c365c581ced11eff954a1f5627e

> 
> Diff: https://reviews.apache.org/r/52459/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message