mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52444: Fixed the MesosContainerizer destroy issue.
Date Fri, 30 Sep 2016 21:01:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52444/#review151085
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Sept. 30, 2016, 1:32 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52444/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 1:32 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When doing recursive destroy, we should return the collected future of
> nested container destroys. Intead, we should fail the corresponding
> termination and return that termination if nested container destroys
> failed.
> 
> In addition, we cannot remove 'Container' struct from the internal map
> when the destroy of a nested container failed. This is to ensure that
> the top level container do not proceed with destroy if any of its
> nested container failed to destroy.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp c542902714ccf2a951bf73fef62902f553d7ea1d

>   src/slave/containerizer/mesos/containerizer.cpp 522d2c37229b07b66a0824c3e246c32f8d803b10

> 
> Diff: https://reviews.apache.org/r/52444/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message