mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52440: Fixed master to properly handle pending tasks.
Date Fri, 30 Sep 2016 20:30:15 GMT


> On Sept. 30, 2016, 8:23 p.m., Anand Mazumdar wrote:
> > src/master/master.cpp, line 3689
> > <https://reviews.apache.org/r/52440/diff/2/?file=1517195#file1517195line3689>
> >
> >     Can we log here before we remove the tasks?

as discussed offline, we don't log about removing pending tasks in anywhere, so just doing
it here seems inconsistent.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52440/#review151069
-----------------------------------------------------------


On Sept. 30, 2016, 8:21 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52440/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6299
>     https://issues.apache.org/jira/browse/MESOS-6299
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pending tasks are always removed from frameworks `pending` map,
> irrespective of whether the task launch is successful or not.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 756ab546851952bc1de24b1f469d232237b1c01c 
>   src/tests/master_authorization_tests.cpp 74422c7a185e50eef32a045e55abe5d9ba83bce3 
>   src/tests/master_validation_tests.cpp 16c5773aa44016f923e00cb348ded6b8c46d4b4b 
> 
> Diff: https://reviews.apache.org/r/52440/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also confirmed that all the updated tests fail without the fix.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message