mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52432: Reenabled the 'HealthCheckTest.GracePeriod' test.
Date Fri, 30 Sep 2016 18:12:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52432/
-----------------------------------------------------------

(Updated Sept. 30, 2016, 6:12 p.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Changes
-------

Added changes done by haosdent in https://reviews.apache.org/r/47089. So this RR is basically
the same as 47089, I'm fine with dropping this one in favour of haosdent's commit.


Repository: mesos


Description
-------

This test was disabled in 2014 because it was considered flaky. I
updated it so that it runs quicker and ran it 1000 times without a
single failure.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 

Diff: https://reviews.apache.org/r/52432/diff/


Testing
-------

bin/mesos-tests.sh --verbose --gtest_filter="HealthCheckTest.GracePeriod" --break-on-error
--gtest_repeat=1000


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message