mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.
Date Fri, 30 Sep 2016 16:50:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review151036
-----------------------------------------------------------



Bad patch!

Reviews applied: [52311, 52310, 52309, 52308]

Failed command: ./support/apply-review.sh -n -r 52309

Error:
2016-09-30 16:50:55 URL:https://reviews.apache.org/r/52309/diff/raw/ [1106/1106] -> "52309.patch"
[1]
error: patch failed: src/slave/container_loggers/lib_logrotate.cpp:173
error: src/slave/container_loggers/lib_logrotate.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15468/console

- Mesos ReviewBot


On Sept. 30, 2016, 3:28 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set the executorInfo user before the custom executor code flow.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 
> 
> Diff: https://reviews.apache.org/r/52311/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs
are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting
rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message