mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 52416: Made 'parse' method in linux launcher take a real cgroup path.
Date Fri, 30 Sep 2016 15:19:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52416/#review151021
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/linux_launcher.cpp (line 276)
<https://reviews.apache.org/r/52416/#comment219148>

    Fix the comment now.


- Benjamin Hindman


On Sept. 30, 2016, 5:15 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52416/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 5:15 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we pass a 'stripped' cgroup path the parse function. This
> is a little confusing to the reader. This patch move the 'strip' logic
> to the parse function so that its parameter makes more sense.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 1bce077e4aa97425b9cbdf8576a5dd52851c044e

> 
> Diff: https://reviews.apache.org/r/52416/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message