mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52357: Improved handling of health check failures within the grace period.
Date Fri, 30 Sep 2016 11:29:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52357/
-----------------------------------------------------------

(Updated Sept. 30, 2016, 11:29 a.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Changes
-------

Followed the suggestions from AlexR and Haosdent, which led to way fewer boilerplate in the
test.


Bugs: MESOS-6170
    https://issues.apache.org/jira/browse/MESOS-6170


Repository: mesos


Description
-------

The health check library would ignore all failures until after the end
of the grace period.

This behaviour was misleading. With the changes in this commit, once a
health check succeeds for the first time, the grace period rule for
failures is not be applied any more.


Diffs (updated)
-----

  src/health-check/health_checker.cpp ea93132f2a5d4828c75005f102eddc4c3131599d 
  src/tests/health_check_tests.cpp e6b02f23dc1b1b84381ab0af0e3df5918b60ae40 

Diff: https://reviews.apache.org/r/52357/diff/


Testing
-------

Manual tests using Marathon.
Added a new unit test and verified that it fails without the change, but succeeds with it.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message