mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 52412: Supported logger with nested containers in Mesos Containerizer.
Date Fri, 30 Sep 2016 01:14:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52412/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Jie Yu, and Joseph Wu.


Bugs: MESOS-6290
    https://issues.apache.org/jira/browse/MESOS-6290


Repository: mesos


Description
-------

Currently, there are two issues in mesos containerizer using logger
for nested contaienrs:
1. An empty executorinfo is passed to logger when launching a nested
   container, it would potentially break some logger modules if any
   module tries to access the required proto field (e.g., executorId).
2. The logger does not reocver the nested containers yet in
   MesosContainerizer::recover.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 522d2c37229b07b66a0824c3e246c32f8d803b10


Diff: https://reviews.apache.org/r/52412/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message