mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50491: Added PIDGroup to libprocess.
Date Fri, 30 Sep 2016 00:00:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50491/#review150959
-----------------------------------------------------------




3rdparty/libprocess/include/process/pid_group.hpp (lines 57 - 64)
<https://reviews.apache.org/r/50491/#comment219068>

    Add a comment here that these methods are meant to be called by the class implementing
the `PIDGroup`.  
    
    Also note that these methods are not `protected` so that they can be used in tests.



3rdparty/libprocess/include/process/pid_group.hpp (line 77)
<https://reviews.apache.org/r/50491/#comment219067>

    s/> > >/>>>/



3rdparty/libprocess/include/process/pid_group.hpp (line 98)
<https://reviews.apache.org/r/50491/#comment219069>

    Hm, why is this in the header?  It can easily go into the .cpp file.



3rdparty/libprocess/include/process/pid_group.hpp (lines 160 - 161)
<https://reviews.apache.org/r/50491/#comment219070>

    Looks like the spacing of this was originally wrong.  It should be:
    ```
    return process::dispatch(
        process, 
        &PIDGroupProcess::broadcast<Req, Res>,
        protocol, 
        req, 
        filter);
    ```


- Joseph Wu


On Aug. 5, 2016, 1:16 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50491/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 1:16 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5828
>     https://issues.apache.org/jira/browse/MESOS-5828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Log network is not specific to replicated log and the name 'network'
> is also confusing. Therefore, PIDGroup is added to libprocess as a
> replacement for network. This is a step towards modularizing the
> PIDGroup abstraction alongside the `MasterContender` and
> `MasterDetector`.
> 
> Note: The PIDGroup abstraction is a component that discovers all masters
> in the group; whereas the `MasterDetector` only discovers the leader
> of the group. Both are necessary for the replicated log.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 020b0e1e4c49805a3c7a61b308d897fc82f5e0ce 
>   3rdparty/libprocess/include/Makefile.am a27e9f7aaa2b45139d4eb95f365d8b2041d7aad2 
>   3rdparty/libprocess/include/process/pid_group.hpp PRE-CREATION 
>   3rdparty/libprocess/src/pid_group.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/pid_group_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50491/diff/
> 
> 
> Testing
> -------
> 
> see the end of review chain.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message