mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52408: Disallowed HTTP executors to subscribe before containerizer recovery.
Date Thu, 29 Sep 2016 22:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52408/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 10:36 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Review comments


Bugs: MESOS-6274
    https://issues.apache.org/jira/browse/MESOS-6274


Repository: mesos


Description
-------

Previously, it was possible for a HTTP based executor to subscribe
with the agent before the containerizer recovery is done. This
was a problem since calling `containerizer->update()` etc. would
result in a failure.


Diffs (updated)
-----

  src/slave/http.cpp ff750e23433ce241d76c3b163b8442f9bd4657b1 
  src/slave/slave.hpp 7b414d06ffac6db8434ba5c4e7be1989f2ca0864 
  src/slave/slave.cpp 46bc8b38cf38c20b01532455b4d369221775c837 
  src/tests/executor_http_api_tests.cpp 14a907f1955513fbcd46af2fc65c1ce5c85bf8cb 

Diff: https://reviews.apache.org/r/52408/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message