mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52364: Added basic support to invoke `docker.exe`.
Date Thu, 29 Sep 2016 21:19:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52364/#review150932
-----------------------------------------------------------




src/docker/docker.cpp (lines 62 - 66)
<https://reviews.apache.org/r/52364/#comment219020>

    We should just add these as Subprocess helpers.  We have `/dev/null` sprinkled over the
codebase...
    
    In `process/subprocess_base.hpp`:
    ```
    class Subprocess
    {
      ...
      
      static IO DEV_NULL(); // Or a different name, not sure what I prefer.
      ...
    }
    ```
    
    With an implementation in `src/subprocess_posix.cpp`:
    ```
    Subprocess::IO Subprocess::DEV_NULL()
    {
      return Subprocess::PATH("/dev/null");
    }
    ```
    
    And an implementation in `src/subprocess_windows.cpp`:
    ```
    Subprocess::IO Subprocess::DEV_NULL()
    {
      return Subprocess::PATH("nul");
    }
    ```



src/slave/containerizer/docker.cpp (lines 91 - 95)
<https://reviews.apache.org/r/52364/#comment219044>

    Does this actually cause problems on Windows?  (is there a strict requirement for windows-style
paths?)


- Joseph Wu


On Sept. 28, 2016, 1:54 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52364/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used platform specific null device string.
> Alled use of `npipe` as `Docker` socket.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb 
>   src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 
>   src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 
> 
> Diff: https://reviews.apache.org/r/52364/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message