mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.
Date Thu, 29 Sep 2016 21:11:20 GMT


> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote:
> > src/health-check/health_checker.cpp, line 117
> > <https://reviews.apache.org/r/51607/diff/1/?file=1490612#file1490612line117>
> >
> >     Shouldn't we check is this directory exists before creating this `HealthCheckerProcess`?

Probably not, we don't do it in `launchTaskPosix()`, moreover this flag is required for executors.


> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote:
> > src/health-check/health_checker.cpp, line 520
> > <https://reviews.apache.org/r/51607/diff/1/?file=1490612#file1490612line520>
> >
> >     This more of a question:
> >     Why is the --host hard coded to the `DEFAULT_DOMAIN`. What if the container
is binding to a specific IP address, instead of any ADDR_ANY? Also, in case of the docker
containerizer, the `tcpConnect` binary is going to be running in the host network namespace
so connecting to localhost might work for cases where the port-mapping is setup for the containers,
but don't think it will work for cases where the container (docker container) has no port
mapping but has it own network namespace. This will happen say with Calico or even the DC/OS
overlay.

We decided that for simplicity. Is it always the case that the one can tell what ip the task
will have before launching the task? Probably no, and we'll end up using discovery info for
that task. Localhost sounds like a minimal solution, but yes, the container should bind to
all interfaces.

In the docker case the `tcpConnect` binary will be running in the container's network namespace,
so it should be fine.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51607/#review147887
-----------------------------------------------------------


On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51607/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, and haosdent
huang.
> 
> 
> Bugs: MESOS-6119
>     https://issues.apache.org/jira/browse/MESOS-6119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp f5981b080c0b81ef7025527ab26b36d7a01f009b 
>   src/health-check/health_checker.hpp 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
>   src/health-check/health_checker.cpp f373df19fc8af8e9650be61e3b101e89362a67cd 
>   src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a 
> 
> Diff: https://reviews.apache.org/r/51607/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.11.6
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message