mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51606: Libprocess: Added target for "mesos-tcp-connect" binary.
Date Thu, 29 Sep 2016 20:54:14 GMT


> On Sept. 6, 2016, 3:31 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 155-159
> > <https://reviews.apache.org/r/51606/diff/1/?file=1490609#file1490609line155>
> >
> >     I think we need to put this after `MESOS_DOCKER_EXECUTOR` to keep the order

I though we maintain alphabetical order, no?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51606/#review147845
-----------------------------------------------------------


On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51606/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and haosdent huang.
> 
> 
> Bugs: MESOS-6119
>     https://issues.apache.org/jira/browse/MESOS-6119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake f7cba60c9ef7c7ed27819dcf4939c0c51f80d49e

> 
> Diff: https://reviews.apache.org/r/51606/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/51607/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message