mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52405: Skipped isolator callbacks for nested containers if needed.
Date Thu, 29 Sep 2016 20:43:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52405/#review150933
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (lines 1726 - 1731)
<https://reviews.apache.org/r/52405/#comment219021>

    This is not needed, because:
    1. We already have a `CHECK` at the very beginning of `MesosContainerizerProcess::update()`.
    2. `MesosContainerizerProcess::update()` will only be called in the agent with `executor->containerId`,
which has to be a top level container.
    
    I would prefer to just leave a NOTE in comment here.



src/slave/containerizer/mesos/containerizer.cpp (lines 1795 - 1800)
<https://reviews.apache.org/r/52405/#comment219023>

    ditto.


- Gilbert Song


On Sept. 29, 2016, 1:15 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52405/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues.
> 
> 
> Bugs: MESOS-6284
>     https://issues.apache.org/jira/browse/MESOS-6284
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If an isolator is not nesting aware (which is the default), the
> containerizer should not try to call its callbacks when dealing with
> nested container. This patch makes sure this is properly handled.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 31064aefa6053eb65fbb2855929118e798b131ad

> 
> Diff: https://reviews.apache.org/r/52405/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message