mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.
Date Thu, 29 Sep 2016 20:09:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 29, 2016, 8:09 p.m.)

Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.



Bugs: MESOS-6134

Repository: mesos


This fixes cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker

Note: we have to add the boolean variable to `Docker` class
because `Docker::run()` has reached the maximum argument length
GMOCK can support.

Diffs (updated)

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 24a6e14fbe5f3aa5b7b7538f33473a564dfbd682 
  src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f 
  src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 
  src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 
  src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c 



I am now able to make docker containers launched through mesos-execute have a cpu quota.

Also making sure `make check` still works on mac os for the linux only flag.


Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message