mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52357: Improved handling of health check failures within the grace period.
Date Thu, 29 Sep 2016 20:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52357/#review150922
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 1333)
<https://reviews.apache.org/r/52357/#comment218999>

    s/Testing/Tests
    
    Let's repeat what we test and how.



src/tests/health_check_tests.cpp (lines 1339 - 1340)
<https://reviews.apache.org/r/52357/#comment219004>

    I wonder whether we really need these lines.



src/tests/health_check_tests.cpp (line 1342)
<https://reviews.apache.org/r/52357/#comment219005>

    This can also go.



src/tests/health_check_tests.cpp (line 1373)
<https://reviews.apache.org/r/52357/#comment219008>

    Let's name it similar to test case.



src/tests/health_check_tests.cpp (line 1387)
<https://reviews.apache.org/r/52357/#comment219010>

    s/alt/healthCheckCmd ?



src/tests/health_check_tests.cpp (lines 1401 - 1402)
<https://reviews.apache.org/r/52357/#comment219012>

    .WillRepeatedly(Return()); // Ignore subsequent updates.


- Alexander Rukletsov


On Sept. 29, 2016, 3:30 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52357/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 3:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-6170
>     https://issues.apache.org/jira/browse/MESOS-6170
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The health check library would ignore all failures until after the end
> of the grace period.
> 
> This behaviour was misleading. With the changes in this commit, once a
> health check succeeds for the first time, the grace period rule for
> failures is not be applied any more.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp ea93132f2a5d4828c75005f102eddc4c3131599d 
>   src/tests/health_check_tests.cpp e6b02f23dc1b1b84381ab0af0e3df5918b60ae40 
> 
> Diff: https://reviews.apache.org/r/52357/diff/
> 
> 
> Testing
> -------
> 
> Manual tests using Marathon.
> Added a new unit test and verified that it fails without the change, but succeeds with
it.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message