mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51031: Added non-recursive version of `cgroups::get`.
Date Thu, 29 Sep 2016 17:35:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 5:35 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
-------

Rebase.


Bugs: MESOS-6035
    https://issues.apache.org/jira/browse/MESOS-6035


Repository: mesos


Description
-------

In most cases, we just want to get the children cgroups instead of
retrieve descendant cgroups recursively. We added an argument to
`cgroups::get` to indicate whether retrieve cgroups recursively and
make non-recursive retrieve become the default behaviour. This patch
fixed some incorrect `TEST_CGROUPS_ROOT` checks as well.


Diffs (updated)
-----

  src/linux/cgroups.hpp 3c9d9e21c8332668286e4170be711aa260c12c1d 
  src/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d 
  src/tests/containerizer/cgroups_tests.cpp 0afaec6ae948cabf1472bf01103210d8f9809cb1 
  src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2 

Diff: https://reviews.apache.org/r/51031/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message