-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52301/#review150860
-----------------------------------------------------------
Fix it, then Ship it!
I'll fix the outstanding issues and commit it shortly.
src/tests/health_check_tests.cpp (line 1333)
<https://reviews.apache.org/r/52301/#comment218937>
Let's expand the comment explaning why the test is here.
src/tests/health_check_tests.cpp (lines 1342 - 1348)
<https://reviews.apache.org/r/52301/#comment218936>
Do you really need these?
src/tests/health_check_tests.cpp (line 1370)
<https://reviews.apache.org/r/52301/#comment218938>
This may take up to `1s`. Let's make sure we don't slow down the test because of the allocation
interval.
src/tests/health_check_tests.cpp (lines 1375 - 1377)
<https://reviews.apache.org/r/52301/#comment218935>
Let's swap these lines.
- Alexander Rukletsov
On Sept. 29, 2016, 4:22 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52301/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2016, 4:22 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
>
>
> Bugs: MESOS-6110
> https://issues.apache.org/jira/browse/MESOS-6110
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test case `HealthCheckTest.HealthyTaskViaHTTPWithoutType`.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp e6b02f23dc1b1b84381ab0af0e3df5918b60ae40
>
> Diff: https://reviews.apache.org/r/52301/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|