mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 50271: Created an isolator for Linux capabilities.
Date Thu, 29 Sep 2016 16:20:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50271/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 6:20 p.m.)


Review request for mesos, Jay Guo and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-5275
    https://issues.apache.org/jira/browse/MESOS-5275


Repository: mesos


Description
-------

This isolator evaluates agent allowed capabilities and passes net
capabilities on to `mesos-containerizer` which enforces the
capabilities.

Capability information is passed via a new field in
`ContainerLaunchInfo`.


Diffs (updated)
-----

  include/mesos/slave/containerizer.proto 86d1859854b44f237ac2ca1ef74982b543c08d25 
  src/CMakeLists.txt 35eb63fe9a8e47d97512e9904bf5a714c63722a7 
  src/Makefile.am f093000e0282a8d5ac17e7ba33711690ccdfe68a 
  src/slave/containerizer/mesos/containerizer.cpp 31064aefa6053eb65fbb2855929118e798b131ad

  src/slave/containerizer/mesos/isolators/linux/capabilities.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/linux/capabilities.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch.hpp a9b6ee2f0da2c1c84c6a0642adbce20a9f0218dc 
  src/slave/containerizer/mesos/launch.cpp 7cc0c3f46fe1a5883b7ccd474595b8be412b355c 
  src/slave/flags.hpp 3952d04f6a00ac1dca1adf2bea7cc6e415620ce5 
  src/tests/containerizer/isolator_tests.cpp 9458e7ef205c1e7ed496b53cd28ffc23e1dc1401 

Diff: https://reviews.apache.org/r/50271/diff/


Testing
-------

`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
`make` (OS X, clang-4.0 w/o optimizations)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message