mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52384: Correctly used variables in test shell scripts.
Date Thu, 29 Sep 2016 14:18:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52384/#review150848
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 29, 2016, 12:58 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52384/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 12:58 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Correctly used variables in test shell scripts.
> 
> 
> Diffs
> -----
> 
>   src/tests/balloon_framework_test.sh 0b135a6988c5d12a77d9074f898b8fceaefe6fd4 
>   src/tests/disk_full_framework_test.sh e13d4678e0dac910ea5409cdc42b9015d62af511 
> 
> Diff: https://reviews.apache.org/r/52384/diff/
> 
> 
> Testing
> -------
> 
> * checked that the changed scripts do output red text on failure
> * checked that `(cd src/tests && grep '{' *sh | grep -v '${')` returns only expected
patterns
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message