mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 52388: Added compile-time check for correct inheritance in Flags hierarchies.
Date Thu, 29 Sep 2016 12:55:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52388/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-3335
    https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
-------

The base class of the flags hierarchy `FlagsBase` stores a `map` of all
known flags. This make it necessary to only inherit `virtual`ly from
`FlagsBase` (otherwise we would have multiple `map`s and not know
where to look up a certain flag).

This commit adds a compile-time check to catch cases where users
inherit non-`virual`ly from `FlagsBase`.


Diffs
-----

  3rdparty/stout/include/stout/flags/flags.hpp eab8a001ed19755de58386a55ed4972f58026b29 

Diff: https://reviews.apache.org/r/52388/diff/


Testing
-------

Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various
Linux configurations in internal CI..


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message