mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in libprocess.
Date Thu, 29 Sep 2016 12:55:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46823/
-----------------------------------------------------------

(Updated Sept. 29, 2016, 2:55 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
-------

Rebased.


Summary (updated)
-----------------

Fully qualified addresses of Flag members in add calls in libprocess.


Bugs: MESOS-3335
    https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
-------

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211


Diff: https://reviews.apache.org/r/46823/diff/


Testing (updated)
-------

Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various
Linux configurations in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message