mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.
Date Thu, 29 Sep 2016 12:54:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52387/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-3335
    https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
-------

Consistently used virtual inheritance for Flags classes in libprocess.


Diffs
-----

  3rdparty/libprocess/include/process/ssl/flags.hpp 13fa7a0cc9d6d6d6849976a3ce383263c51504d7

  3rdparty/libprocess/src/tests/ssl_client.cpp 8d62fc2975b585013a8d9a6efc967314d6d8ec47 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211


Diff: https://reviews.apache.org/r/52387/diff/


Testing
-------

Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various
Linux configurations in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message