mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 51560: Support health check without specifying `type`.
Date Thu, 29 Sep 2016 12:26:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51560/#review150843
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Sept. 29, 2016, 4:21 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51560/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 4:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Absence of `type` in command health check and HTTP health check are
> supported for backwards compatibility and will be deprecated in
> Mesos 2.0.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 
> 
> Diff: https://reviews.apache.org/r/51560/diff/
> 
> 
> Testing
> -------
> 
> Test case is https://reviews.apache.org/r/52301/
> 
> ```
> W0927 22:24:06.558188 117159 master.cpp:4079] The type of health check is not set; use
of 'HealthCheck' without specifying 'type' will be deprecated in Mesos 2.0
> ...
> [       OK ] HealthCheckTest.HealthyTaskViaHTTPWithoutType (946 ms)
> [----------] 1 test from HealthCheckTest (972 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1005 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message