mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 43105: Prevented the allocator from potentially double accounting resources.
Date Thu, 29 Sep 2016 10:32:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43105/#review150837
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Sept. 29, 2016, 10:30 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43105/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, `addSlave()` only adds the used resources of a framework
> if the framework is currently registered. The same is not true for
> `addFramework()`: prior to this patch, allocator added used
> resources of a framework even if the agent is not registered yet.
> 
> This is currently not broken because Mesos master populates
> frameworks' used resources based on the registered agents only.
> However, if we were to call `addFramework()` with resources from
> unregistered agents (i.e. for which `addSlave()` had not been
> called), double accounting of resources would occur.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 41a9d457286e30431490ca626e680d85684b48d6 
>   src/master/allocator/mesos/hierarchical.cpp 7d4064535a20b93950f5a95eef1ad3f0d37d305b

> 
> Diff: https://reviews.apache.org/r/43105/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message