mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52350: Used flags.cgroups_root in nested freezer cgroups.
Date Thu, 29 Sep 2016 06:03:54 GMT


> On Sept. 29, 2016, 5:44 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/linux_launcher.cpp, lines 273-287
> > <https://reviews.apache.org/r/52350/diff/3/?file=1514700#file1514700line273>
> >
> >     If we have cgroups like:
> >     ```
> >     /sys/fs/cgroup/freezer/mesos/<x>/mesos/<y>
> >     ```
> >     
> >     Should we ignore the following? The current code will detect <x>.<z>
as a nested container?
> >     ```
> >     /sys/fs/cgroup/freezer/mesos/<x>/<z>
> >     ```

I still suggest that we factor out this into a helper: Result<ContainerID> getContainerId(cgroup).
None() means the cgroup should be ignored, it's not correlated with a container (or nested
container).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52350/#review150815
-----------------------------------------------------------


On Sept. 29, 2016, 3:24 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52350/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 3:24 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used flags.cgroups_root in nested freezer cgroups.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp dc0633e4e68d83ce4fd75be198070251295ef1c9

> 
> Diff: https://reviews.apache.org/r/52350/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message