mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52376: Created symlink from child container to task on the default executor.
Date Thu, 29 Sep 2016 05:55:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52376/#review150816
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp (line 434)
<https://reviews.apache.org/r/52376/#comment218883>

    s/TASK/TASKS/
    s/CONTAINER/CONTAINERS/


- Vinod Kone


On Sept. 29, 2016, 5:53 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52376/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 5:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6272
>     https://issues.apache.org/jira/browse/MESOS-6272
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We currently don't expose the mapping from the child `ContainerId`
> to the `TaskID` of the task on the agent. This makes it very
> difficult for the WebUI/other tools to construct the path to the
> task sandbox. This change modifies the default executor to create
> a symlink from '.tasks/taskId' to the 'containers/containerId'
> folder thereby allowing these tools to look up the task sandbox
> in the 'tasks' folder.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 129c16185a16c292e655403a55781c2c9c569e4f 
>   src/tests/default_executor_tests.cpp 0f53fe72eb92f66edef5e9623ea28fa939e4c657 
> 
> Diff: https://reviews.apache.org/r/52376/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + make check (validated symlink is created)
> ls -al /tmp/mesos_slave1/slaves/d53ae09b-e915-4108-9326-616b6f1de616-S2/frameworks/d53ae09b-e915-4108-9326-616b6f1de616-0003/executors/default-executor/runs/latest/.tasks
> total 16
> lrwxrwxrwx 1 faceoff faceoff  234 Sep 28 19:49 task1 -> /tmp/mesos_slave1/slaves/d53ae09b-e915-4108-9326-616b6f1de616-S2/frameworks/d53ae09b-e915-4108-9326-616b6f1de616-0003/executors/default-executor/runs/a9fc4117-f789-4798-b048-633d23923e55/containers/3b0169f2-a2b0-4631-a032-7f7dfee7a4ad
> lrwxrwxrwx 1 faceoff faceoff  234 Sep 28 19:49 task2 -> /tmp/mesos_slave1/slaves/d53ae09b-e915-4108-9326-616b6f1de616-S2/frameworks/d53ae09b-e915-4108-9326-616b6f1de616-0003/executors/default-executor/runs/a9fc4117-f789-4798-b048-633d23923e55/containers/2878a965-3215-4a2e-85cf-0847b77f236f
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message