mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51028: Fix tests with rapidly triggered allocations.
Date Thu, 29 Sep 2016 03:06:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review150798
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (lines 3003 - 3004)
<https://reviews.apache.org/r/51028/#comment218859>

    I think that here the comments should also be updated, the `two calls` is actually invoked
by two pair of `addSlave` and `addFramework` for agent1 and agent2.
    
    A suggestion as following:
    
    ```
    // Trigger at least two calls to allocate occur to
    // generate the window statistics. With batching
    // allocation, here we are using two pair of
    // `addSlave` and `addFramework` to trigger two
    // calls.
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 3005 - 3009)
<https://reviews.apache.org/r/51028/#comment218860>

    Just a question here, can we always guarantee only one `allocate()` will be called? I
think that this depends on the speed of dispatching the `run` request.



src/tests/hierarchical_allocator_tests.cpp 
<https://reviews.apache.org/r/51028/#comment218858>

    Instead of killing this part, what about updating `offerCallback` function to record the
number of `agents`? And then assert the number of `agents` here is same as number of agents
in cluster.


- Guangya Liu


On 九月 28, 2016, 9:16 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
> 
> (Updated 九月 28, 2016, 9:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Per MESOS-3157, if cluster events with the possibility
>   of triggering an allocation occur rapidly and test
>   assertions depend on gleaning information from assumed
>   order, it is likely they will fail due to lack of parity
>   between event and actual allocation. Ensure that expected
>   allocations occur.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 46553f6d501deb37862dd5ba48be1c114f6e6cb8

> 
> Diff: https://reviews.apache.org/r/51028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message